Value Types: Replace arraycopy source and destination with temps #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing for null restricted arraycopy transformation, there are temps created for the source array and the destination array. Other sub transformations that run after the preparation and before null-restrcited arraycopy transformation are not aware of these temps. These temps might not get updated properly. This change replaces all the commoned source array node and commoned destination array node with the temps right after the temps are created. Fixes: eclipse-openj9/openj9#20522 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
changed the title
|
@hzongaro May I ask you to review this change? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing for null restricted arraycopy transformation, there are temps created for the source array and the destination array. Other sub transformations that run after the preparation and before null-restrcited arraycopy transformation are not aware of these temps. These temps might not get updated properly. This change replaces all the commoned source array node and commoned destination array node with the temps right after the temps are created.
Fixes: eclipse-openj9/openj9#20522